Add fanout pour net map props - #766
Merged
Merged
Conversation
seveibar
changed the title
seveibar
marked this pull request as ready for review
July 30, 2026 19:55
Contributor
Author
|
CC @0hmX |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+45
to
+64
| test("autorouting phase accepts fanout routing layers", () => { | ||
| const parsed = autoroutingPhaseProps.parse({ | ||
| autorouter: "fanout", | ||
| fanoutRoutingLayers: ["top", { name: "inner3" }, "bottom"], | ||
| }) | ||
|
|
||
| expect(parsed.fanoutRoutingLayers).toEqual(["top", "inner3", "bottom"]) | ||
| }) | ||
|
|
||
| test("autorouting phase accepts a fanout pour net map", () => { | ||
| const raw = { | ||
| autorouter: "fanout", | ||
| fanoutPourNetMap: { | ||
| inner1: "GND", | ||
| inner2: ["VCC_CORE", "VCC_IO"], | ||
| }, | ||
| } satisfies AutoroutingPhaseProps | ||
|
|
||
| expect(autoroutingPhaseProps.parse(raw)).toEqual(raw) | ||
| }) |
Contributor
There was a problem hiding this comment.
A *.test.ts file may have AT MOST one test(...). This file already had at least one test before these additions, and now two more test(...) calls are being added (lines 45 and 54), bringing the total well above one. Per the style guide, each test should be split into its own numbered file, e.g. autoroutingphase1.test.ts, autoroutingphase2.test.ts, autoroutingphase3.test.ts, etc.
Spotted by Graphite (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fanoutRoutingLayersto keep boundary-routed signal escapes off reserved plane layersfanoutPourNetMapto map a layer to one net or an array of isolated nets<bus>focused on ordinary multi-connection bus groupingWhy
Power and ground plane drops are properties of the board stackup and copper
intent, not special singleton buses. Core can infer the same map from
<copperpour>components when the prop is omitted.Validation
bun test tests/bus.test.ts tests/autoroutingphase.test.ts— 16 passedbun run typecheckbun run buildbun run format